Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken prompt set up by activate.bat (#2225) #2226

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

SigmundVik
Copy link
Contributor

@SigmundVik SigmundVik commented Oct 27, 2021

Removing the stray closing parenthesis in activate.bat in commit
35ec441 broke the virtual environment prompt prefix in Windows cmd.
The reason for this was that the ill-formed closing parenthesis
somehow affected the variable expansion order.

This commit fixes the issue by not using a local ENV_PROMPT
variable to update the prompt. (So an additional benefit of
this change is one less variable set in the environment.)

Fixes: #2225

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

Removing the stray closing parenthesis in activate.bat in commit
35ec441 broke the virtual environment prompt prefix in Windows cmd.
The reason for this was that the ill-formed closing parenthesis
somehow affected the variable expansion order.

This commit fixes the issue by not using a local ENV_PROMPT
variable to update the prompt.  (So an additional benefit of
this change is one less variable set in the environment.)

Fixes: pypa#2225
@gaborbernat
Copy link
Contributor

Thank you for putting this in. I'll be able to have a look at it tomorrow morning.

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 31f3913 into pypa:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parenthesis issue in activate.bat - caused by PR 2221
2 participants